[NOREF] add support for queryParams and scheme #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smeb
commented
Sep 29, 2023
| // The rule will not match if only a subsequence of the string matches the regex. | ||
| // https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#envoy-v3-api-field-config-route-v3-routematch-safe-regex | ||
| r, err := regexp.Compile("^" + sm.GetRegex() + "$") | ||
| if err != nil { | ||
| return false, fmt.Errorf("could not compile regex %s: %v", sm.GetRegex(), err) | ||
| } | ||
| return r.MatchString(s), nil | ||
| default: | ||
| return false, fmt.Errorf("unknown matcher type %T", sm.GetMatchType()) |
There was a problem hiding this comment.
Returning an error here is a behaviour change - could also be a log
cainelli
reviewed
Oct 2, 2023
| URI string | ||
| Headers map[string]string | ||
| Scheme string | ||
| QueryParams map[string]string |
There was a problem hiding this comment.
Do we need a separate field for the parameters or can we use the uri and parse from it?
Also, the same parameter can be set multiple times and interpreted differently by web frameworks as there is no apparent standard, this would be another reason not to use map[string]string
There was a problem hiding this comment.
As discussed will keep as is for now - the envoy behaviour is to check the first query param
cainelli
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.